[Breaking] Change the CFT data interface#171
Merged
Merged
Conversation
borisdevos
reviewed
Apr 20, 2026
borisdevos
reviewed
Apr 20, 2026
Co-authored-by: Boris De Vos <143942306+borisdevos@users.noreply.github.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
After the build completes, the updated documentation will be available here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finally changes the CFT data interface to a unified interface.
It introduces a new struct:
CFTDatawith two fields:The
scaling_dimensionsfield is aSectorVector, from TensorKit.jl, which has the nice feature that it can be indexed as if it were a vector (using scalar indexes, slices, ...), and also with sectors (e.g.Z2Irrep(0)).The default shape of transfer matrix is now
[sqrt(2), 2sqrt(2), 0], which is both cheap and good.CFTData can be generated with:
where the last signature is used when the shape requires intermediate trunctation to manage comp. cost. (i.e. [1,8,1] and [4 / sqrt(10), 2 * sqrt(10), 2 / sqrt(10)])
The shapes implemented are:
truncandtruncentanglementtruncandtruncentanglementWhat is left to do is add some explanation about this to the documentation.