can now add any number of additional svds after truncbelow#39
Merged
Jutho merged 2 commits intoQuantumKitHub:masterfrom Jul 1, 2020
Merged
can now add any number of additional svds after truncbelow#39Jutho merged 2 commits intoQuantumKitHub:masterfrom
Jutho merged 2 commits intoQuantumKitHub:masterfrom
Conversation
Jutho
reviewed
Jun 30, 2020
Jutho
reviewed
Jun 30, 2020
| end | ||
| trunc.addone && (truncdim[findmax(next_val)[2]]+=1) | ||
| for i in 1:trunc.add_back | ||
| key_max = findmax(next_val)[2] |
Member
There was a problem hiding this comment.
Did you test this? Is this not looking for the maximum of a bunch of vectors, which I think is not defined?
Member
There was a problem hiding this comment.
There is also argmax as alternative to the second argument of findmax
Contributor
Author
There was a problem hiding this comment.
Yes I tested this.
Also expected it to fail but turns out that it it searching for the vector that contains the largest element.
Member
There was a problem hiding this comment.
Ok, it indeed searches for the one which is largest according to a semantic order. So this works because the singular values are sorted in descending order. Nice. That makes it very easy indeed.
Jutho
reviewed
Jun 30, 2020
Contributor
Author
|
I pushed your suggestions. |
Member
|
I'll merge once CI has finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should be the right one :) !