Mooncake forward rules for linalg#434
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
approved these changes
May 28, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Overall looks good to me! Left one small comment but otherwise I'd say good to go
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
approved these changes
May 28, 2026
Member
Author
|
All these failures look unrelated (AMDGPU and macos runners being sad) so I'm going to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added tests and a primitive marker for the projection methods.