braidingtensor special cases#56
braidingtensor special cases#56Jutho merged 15 commits intoQuantumKitHub:masterfrom maartenvd:master
Conversation
|
Thanks; there were still quite a few bugs in my part apparently :-) |
|
How would you avoid the inference failures in artin_braid? |
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 71.02% 67.95% -3.07%
==========================================
Files 34 34
Lines 4224 4441 +217
==========================================
+ Hits 3000 3018 +18
- Misses 1224 1423 +199
Continue to review full report at Codecov.
|
|
Hi Maarten; I did not have the time to review in detail the contraction code and the resolution of resolving all taus by |
|
ah, unfortunately I still had an unpushed commit, containing another special case where scalars did not play well with planar, but also a bugfix for some special case braidingtensor actions. It should be the last of it, as I now have a fully planar copy of mpskit, which I guess is a fairly extensive test. In any case, I don't particularly mind working with a forked copy of tensorkit for the time being - enjoy your holiday first and foremost! |
some special cases for the braidingtensor action (+ some braidingtensor bugfixes)
also includes special case code for artin_braid, when the leg that is being braided is trivial.