Skip to content

Fermion Refactor#81

Merged
Jutho merged 4 commits intomasterfrom
fermion
Sep 25, 2023
Merged

Fermion Refactor#81
Jutho merged 4 commits intomasterfrom
fermion

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented Sep 25, 2023

This PR changes the Fermion implementation such that only FermionParity remains, all other fermionic charges are just ProductCharge with fermionparity as a factor.

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Sep 25, 2023

Look's good; really wondering what is going on with the x86 platform, but ignoring for now. Seems there are some conflicts though, so I cannot rebase and merge?

@lkdvos
Copy link
Copy Markdown
Member Author

lkdvos commented Sep 25, 2023

It's mainly because I have had this locally for a while, the first commit predates quite a bit of the current history. The easiest solution is to squash and merge into a single commit, which keeps the linear history

@Jutho Jutho merged commit e5829e7 into master Sep 25, 2023
@lkdvos lkdvos deleted the fermion branch September 26, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants