-
Notifications
You must be signed in to change notification settings - Fork 2
Add spinless fermions #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is mainly a copy from MPSKitModels, with a renaming of the operators to be consistent with the Hubbard operators as defined here.
add 'n' to exports Co-authored-by: Lukas Devos <ldevos98@gmail.com>
remove comment Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Yue Zhengyuan <yuezy1997@icloud.com>
Co-authored-by: Yue Zhengyuan <yuezy1997@icloud.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Again mainly a copy from MPSKitModels
|
I think I would very much prefer to not define the "half" operators that aren't symmetric by themselves. Since these aren't all that well-defined I feel like this is more a cause for confusion than really a useful feature. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Only allow for contracted tensors. Also changed some naming conventions to match the ones in this package
|
I have left the /utility.jl file in there, even though we don't use it anymore (that is also why the patch coverage is too low). I would be fine with removing this completely, since there is indeed no unique way of splitting the tensors. |
|
Looks good to me overall. Can you again use the same kind of setup for the module, with a |
consistency with other files
This is again mainly a copy from MPSKitModels.
There are some things we should discuss. I talked with @lkdvos about whether we want to allow users to use the single-site operators like
u_plus(that are then contracted to get the symmetric two-site operators) or whether we will only define the contracted versions. The discussion here is similar. Currently, the two-site operators are defined as the contraction of the single-site ones. We could alternatively define them only as the contracted version, similarly to how we now define the Hubbard operators. This would also eliminate the need for the extra utility file.Secondly, I have added a simple test where I use the exact diagonalisation of the two-body operator in a spinless fermion model (see e.g. this paper. I assume this is what you meant with the discussion in #9, @lkdvos, or did you mean something a bit more elaborate? I have similar stuff for the other models, sometimes a bit more elaborate, but I find it hard to find benchmark data for the exact diagonalisation of finite chains for some of these models. Anyway, these other tests will be added in a separate PR.