Revert "fix: aws text content blocks must be non-empty"

[seefs001]

Reverts #3077

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Improved handling of assistant messages containing tool calls by preserving existing content
  • Enhanced tool call argument parsing to gracefully skip invalid entries instead of resetting
  • Streamlined message delta processing for more consistent function argument extraction
  • Optimized content assembly when handling tool uses in message streams

• Tests

  • Updated test framework to use explicit conditionals instead of external dependencies

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4298891 and b1b3def.

📒 Files selected for processing (2)

• relay/channel/claude/relay-claude.go
• relay/channel/claude/relay_claude_test.go

---

Walkthrough

The PR simplifies Claude message relay processing by removing content coercion logic, streamlining tool-call argument parsing to skip invalid calls rather than reset, and directly using PartialJson for stream handling. Test assertions are refactored to remove testify dependency with some test cases removed.

Changes

Cohort / File(s)	Summary
Claude Relay Logic relay/channel/claude/relay-claude.go	Removed automatic null coercion of empty content for assistant messages with ToolCalls; simplified content presence check; replaced common.UnmarshalJsonStr with json.Unmarshal and changed invalid tool-call handling from reset to skip; eliminated intermediate PartialJson transformation, now directly using raw stream data.
Test Refactoring relay/channel/claude/relay_claude_test.go	Removed testify/assert/require dependency and replaced assertions with manual conditionals and t.Fatal/t.Errorf; removed test cases for OpenAI Claude assistant tool calls and malformed arguments; maintained existing test logic for message_start, message_delta, and content_block_delta paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: 补全 streaming message_delta 事件缺失的 input_tokens 和 cache 相关字段 (#2881) #2885: Enriches missing usage fields in message_delta handling, touching the same code path being refactored for PartialJson/argument processing.
• fix: aws text content blocks must be non-empty #3077: Directly addresses assistant message ToolCall handling and tool-call argument defaults in the same relay logic.
• Fix/aws non empty text #3080: Modifies tool-call PartialJson handling with conditional emission logic in the same relay-claude.go file.

Suggested reviewers

• Calcium-Ion

Poem

🐰 Claude's messages now flow so pure,
No coercion tricks, just raw and sure,
Tool calls skip the broken way,
Simpler tests to save the day,
Stream data flows—no transform delay! ✨

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-3077-fix/aws-non-empty-text

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}