Conversation
Resolve conflicts keeping main's updated dependencies (qp-poseidon-core 1.4, crystals-dilithium 2.4, hdwallet 2.3.1), wormhole derivation support, and regenerated flutter_rust_bridge bindings. Combine POS QR screen changes: retain branch's pending-receive tracking alongside main's error-retry UI. Made-with: Cursor
| ? 'Sending' | ||
| ? (isSend ? 'Sending' : 'Receiving') | ||
| : isScheduled | ||
| ? (isSend ? 'Pending' : 'Receiving') |
There was a problem hiding this comment.
This wording become weird when we have scheduled transfer, because isPending is always the initial state.
So, by current logic the label will be,
Sending/Receiving -> Pending/Receiving
There was a problem hiding this comment.
we don't have scheduled for now in the current app so it's ok
it seems reasonable but once we have a design for scheduled, timer, and so on we can revisit
for now the app has no "isScheduled" state since we didn't implement reversible transactions yet
There was a problem hiding this comment.
kind of weird to regress over it. But actually I did refactor on this nested ternary dystopia in my v3 PR, so I will fix it there.
dewabisma
left a comment
There was a problem hiding this comment.
I added comments that need to be cleared up, then it will be good to go
add pending transaction polling service, using it in transaction submission and also on pos screen
rename mining rewards testnet rewards
Uh oh!
There was an error while loading. Please reload this page.