Skip to content

N13/pos v2 check pending#420

Merged
n13 merged 24 commits intomainfrom
n13/pos_v2_check_pending
Apr 26, 2026
Merged

N13/pos v2 check pending#420
n13 merged 24 commits intomainfrom
n13/pos_v2_check_pending

Conversation

@n13
Copy link
Copy Markdown
Collaborator

@n13 n13 commented Mar 21, 2026

  • Fast checking for POS mode
  • Refactor to reuse code
  • Clear cached mining rewards on logout

n13 added 16 commits March 17, 2026 09:58
Resolve conflicts keeping main's updated dependencies (qp-poseidon-core 1.4,
crystals-dilithium 2.4, hdwallet 2.3.1), wormhole derivation support, and
regenerated flutter_rust_bridge bindings.  Combine POS QR screen changes:
retain branch's pending-receive tracking alongside main's error-retry UI.

Made-with: Cursor
@n13 n13 marked this pull request as ready for review April 24, 2026 02:55
? 'Sending'
? (isSend ? 'Sending' : 'Receiving')
: isScheduled
? (isSend ? 'Pending' : 'Receiving')
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording become weird when we have scheduled transfer, because isPending is always the initial state.

So, by current logic the label will be,

Sending/Receiving -> Pending/Receiving

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have scheduled for now in the current app so it's ok

it seems reasonable but once we have a design for scheduled, timer, and so on we can revisit

for now the app has no "isScheduled" state since we didn't implement reversible transactions yet

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of weird to regress over it. But actually I did refactor on this nested ternary dystopia in my v3 PR, so I will fix it there.

Comment thread mobile-app/lib/services/pending_receive_tracker.dart Outdated
Copy link
Copy Markdown
Collaborator

@dewabisma dewabisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments that need to be cleared up, then it will be good to go

n13 added 7 commits April 24, 2026 12:59
add pending transaction polling service, using it in transaction submission and also on pos screen
rename mining rewards testnet rewards
Copy link
Copy Markdown
Collaborator

@dewabisma dewabisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n13 n13 merged commit cd1a51f into main Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants