Conversation
Collaborator
n13
commented
Apr 15, 2026
n13
commented
dewabisma
reviewed
Apr 15, 2026
| 'query': | ||
| ''' | ||
| query { | ||
| minerStats(where: {id_in: [${queryIds.map((id) => '"$id"').join(', ')}]}) { |
Collaborator
There was a problem hiding this comment.
Is this working? usually the safe way to insert query is through variables payload.
dewabisma
reviewed
Apr 15, 2026
dewabisma
reviewed
Apr 15, 2026
dewabisma
reviewed
Apr 15, 2026
dewabisma
requested changes
Apr 15, 2026
Collaborator
dewabisma
left a comment
dewabisma
left a comment
There was a problem hiding this comment.
Overall looking good, some error handling issues and confirmation about the query
fix loading spinner when retrying
Collaborator
Author
|
Yeah.. AI doesn't handle errors lol Added error handling to everything ;) |
dewabisma
reviewed
Apr 15, 2026
|
|
||
| final mappings = await _fetchAccountMappings(); | ||
| print('[MiningRewards] Account mappings total: ${mappings.length} rows'); | ||
| for (final m in mappings) { |
Collaborator
There was a problem hiding this comment.
Seems this looping doesn't have any meaning, please remove this
dewabisma
reviewed
Apr 15, 2026
| if (oldId != null && allIds.add(oldId)) { | ||
| print('[MiningRewards] Chain depth $depth: $id -> $oldId'); | ||
| next.add(oldId); | ||
| } else if (oldId == null) { |
Collaborator
There was a problem hiding this comment.
Do we really need to add if else here if we do nothing?
dewabisma
reviewed
Apr 15, 2026
| total += miner.blocks; | ||
| } | ||
| } | ||
| if (total == 0) print('[MiningRewards] No matches in $network for any of ${accountIds.length} account IDs'); |
Collaborator
There was a problem hiding this comment.
this seems to be not usefull
dewabisma
requested changes
Apr 15, 2026
Collaborator
dewabisma
left a comment
dewabisma
left a comment
There was a problem hiding this comment.
Still need to do some small changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.