Skip to content

Conversation

@syntrust
Copy link

@syntrust syntrust commented Nov 3, 2025

Fix error of just interfaces-check

go run ./scripts/checks/interfaces
2025/11/03 10:03:08 ADD error to interface: error OptimismPortal_NativeDepositForbidden()
2025/11/03 10:03:08 ADD error to interface: error OptimismPortal_Unauthorized()
2025/11/03 10:03:08 ADD event to interface: event NativeDepositDisabled()
2025/11/03 10:03:08 ADD event to interface: event NativeDepositEnabled()
2025/11/03 10:03:08 ADD event to interface: event MinterSet(address minter)
❌  forge-artifacts/IOptimismPortal2.sol/IOptimismPortal2.0.8.15.default.json: differences found
2025/11/03 10:03:08 ADD error to interface: error OptimismPortal_Unauthorized()
2025/11/03 10:03:08 ADD event to interface: event NativeDepositDisabled()
2025/11/03 10:03:08 ADD error to interface: error OptimismPortal_NativeDepositForbidden()
2025/11/03 10:03:08 ADD event to interface: event MinterSet(address minter)
2025/11/03 10:03:08 ADD event to interface: event NativeDepositEnabled()
❌  forge-artifacts/IOptimismPortal2.sol/IOptimismPortal2.0.8.15.dispute.json: differences found
2025/11/03 10:03:09 ADD event to interface: event NativeDepositEnabled()
2025/11/03 10:03:09 ADD event to interface: event MinterSet(address minter)
2025/11/03 10:03:09 ADD event to interface: event NativeDepositDisabled()
2025/11/03 10:03:09 ADD error to interface: error OptimismPortal_NativeDepositForbidden()
2025/11/03 10:03:09 ADD error to interface: error OptimismPortal_Unauthorized()
❌  forge-artifacts/IOptimismPortal2.sol/IOptimismPortal2.0.8.29.default.json: differences found
2025/11/03 10:03:10 ADD event to interface: event NativeDepositDisabled()
2025/11/03 10:03:10 ADD error to interface: error L2ToL1MessagePasser_NativeDepositDisabled()
2025/11/03 10:03:10 ADD event to interface: event NativeDepositEnabled()
❌  forge-artifacts/IL2ToL1MessagePasser.sol/IL2ToL1MessagePasser.dispute.json: differences found
2025/11/03 10:03:10 ADD event to interface: event NativeDepositEnabled()
2025/11/03 10:03:10 ADD error to interface: error L2ToL1MessagePasser_NativeDepositDisabled()
2025/11/03 10:03:10 ADD event to interface: event NativeDepositDisabled()
❌  forge-artifacts/IL2ToL1MessagePasser.sol/IL2ToL1MessagePasser.default.json: differences found
error: processing failed
exit status 1

Copy link

@blockchaindevsh blockchaindevsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can group these interface changes together under the comment /// @notice added by QKC . Same for IL2ToL1MessagePasser.

This reverts commit f529d28.
@syntrust syntrust merged commit 560c64a into op-es Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants