Skip to content

Conversation

@syntrust
Copy link

Fixed semgrep findings about error handling:

semgrep scan --timeout=100 --config .semgrep/rules/ --error .
                                                            
    packages/contracts-bedrock/src/L1/OptimismPortal2.sol
   ❯❯❱ semgrep.rules.sol-style-error-format
          Error formatting is incorrect - must follow pattern
          ContractName_ErrorName with exactly one underscore 
                                                             
          219┆ error NativeDepositForbidden();
                                                                            
    packages/contracts-bedrock/src/L2/L2ToL1MessagePasser.sol
   ❯❯❱ semgrep.rules.sol-style-malformed-revert
          Revert statement style is malformed
                                             
          101┆ revert("native deposit/withdraw is disabled");

@syntrust syntrust merged commit fdaa45e into op-es Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants