Qubes Domains widget doesn't adapt state button to kill after unsuccessful shutdown

[GammaSQ]

Qubes OS release

4.3

Brief summary

In Qubes 4.2, once a VM got stuck, the tray icon allowed you to kill the VM. If I remember correctly, this was reliably the case when a shutdown-attempt had failed or was ongoing. In Qubes 4.3, I don't have found any way to trigger kill-actions from the tray icon.

Steps to reproduce

Have a VM that refuses to shut down. (hanging VMs)

Trigger shutdown from tray icon.

Expected behavior

In Qubes 4.2 its was possible to kill a VM during the shutdown process, but this is currently impossible due to GUI hanging.

After shutdown, the tray icon should offer the option to kill the VM.

Actual behavior

tray icon menus are unchanged. Only Shutdown is offered here.
Killing requires the CLI or qube-manager.

Additional information

[marmarek]

Interesting, when I click "shutdown", I get "kill" option available - which I can use if the shutdown fails. Does it fail for you before menu is changed? Do you get some error message (in a message box, or journalctl --user)?

[GammaSQ]

Oh, I see, that is correct for well behaved VMs.

Sorry, I've only ever tried to shut down hanging VMs it seems. Yes, a well behaved VM can be shut down and in the tray-icon-menu it allows a "kill".
This does not happen with hanging VMs (related to #10648 ) and after the timeout of the shutdown process and subsequent timeout of the kill (i.e. after the modal "Error shutting down qube" appeared), the menu in the tray-icon only offers the usual options again, not "kill".

[marmarek]

shutdown-attempt had failed or was ongoing

Reproducing this condition might be not easy. Normally I'd say simply pause the VM, but currently shutdown of a paused VM is specially handled. Maybe disarm that handling (so self.libvirt_domain.shutdown() gets called) for the test? Alternatively, maybe some sleep state might work, like echo freeze > /sys/power/state?

[GammaSQ]

The only 100% reproducible way to create a freeze I know of is to have an encrypted external drive, attach it to a VM, decrypt it there and attach the newly available dm-0-device to a different VM. mount the block device there and write something to it. shutdown the first VM, then shut down the second VM. shutting down the second VM will cause the hang and finally result in an "Error shutting down qube"-notification. selecting to kill the VM from that pop-up will time-out as well and afterwards (another popup appears) there will be no "kill"-option in the device-tray-icon.

semi-related