integrate qucs tests into qucs package by felix-salfelder · Pull Request #389 · Qucs/qucs

felix-salfelder · 2015-09-30T22:33:01Z

currently some tests are not included with qucs. including these tests will increase test coverage.

with this, make check will run all tests we have, not just few of them.

- add SUFFIXES for .h->.moc.cpp rule - add various _HEADERS - distribute qucs.qrc - add several qrc files - add more filter headers - sort out qm rule - add translation files to dist

using MAINTAINER_MODE does not work, if it it not enabled.

remove maintainer mode condition. rename --with-mkadms to --with-admsxml.

this is required to generate qucsdefs.h. still don't advertise unless DEBUG (for some reason).

autotools does this. dont try manually. (perhaps autotools could not do this back then...)

also editing an xml file. unsure, what this is about.

(does not work yet, need to fix docbuild first)

this works around MAINTAINER_MODE, which is no longer used

use one of them in $srcdir sanity check in configure.ac

qucs-doc conditional only affects toplevel Makefile.am

- set AC_CONFIG_AUX_DIR, so automake will not guess (wrongly) - dont mention autogen in output - AM_PROG_AR. required according to automake output (-Wall)

felix-salfelder · 2015-10-04T16:04:57Z

about coverage. We could have branches specialized for each task. Coverage, static analysis, packaging, doxygen, nightly builds... sure. The .travis.yml grew as I managed to hook more stuff in it. Perhaps it is time to clean it up.

i will/might start/experiment with a develop branch. i am not yet fully familiar with the travis thing. lets add/reassign tasks to other branches as it seems appropriate.

The wget patch 8765e8d is really about Googletest integration (I still don't get what you mean by software distribution...).

in my understanding. a distribution is something that puts together and delivers packages. qucs is one such package. imo it should not try to process other packages.

NB: i am aware of the ADMS "sub"package, i consider this a leftover from times without an ADMS release tarball. or should we also ship a kernel a shell and a c++-compiler...? (imo: no. others are truly better at this).

facilitate the download and compilation.

wget in configure is clearly beyond the scope of the configure program. configure is originally meant to create makefiles (+ related things) -- and this is what the user expects it to do (least-surprise-stuff...). note that the wget command leaks user data, and can fail if there's a firewall. let me suggest to turn the wget block into something like the following.

if $something
  AC_MSG_ERROR([not found. consider running get-$packagename.sh to fetch from $somewhere])
fi

to reduce the surprise factor. i don't insist on removing the functionality :).

this file has unsafe timestamps. use config.h instead. (don't know what else this is used for (cmake?))

"./bootstrap here" does not recurse. sometimes faster.

- dont write to $(srcdir) during configure - simplify --with-gtest semantics - dont download gtest automatically - use GTEST_CPPFLAGS for gtest CPPFLAGS. - add gtest download helper TODO: add wget to .travis.yml

============================================================================ Testsuite summary for qucs-core 0.0.19 ============================================================================ \# TOTAL: 1 \# PASS: 0 \# SKIP: 1 \# XFAIL: 0 \# FAIL: 0 \# XPASS: 0 \# ERROR: 0 ============================================================================ .. rather than ignore it ============================================================================ Testsuite summary for qucs-core 0.0.19 ============================================================================ \# TOTAL: 0 \# PASS: 0 \# SKIP: 0 \# XFAIL: 0 \# FAIL: 0 \# XPASS: 0 \# ERROR: 0 ============================================================================

felix-salfelder · 2015-11-06T10:31:11Z

this seems to be working as intended now..

.. in an attempt to figure out what's wrong with appvey0r

guitorri · 2016-01-24T16:26:26Z

Looking good! Is there anything else you want to do here?

Yesterday I was about to merge this.
I got some issue with make distcheck (dist and check worked), related to qucs-core\tests\basic. I will try to reproduce.

felix-salfelder · 2016-01-24T16:32:44Z

Looking good! Is there anything else you want to do here?

no. that's it. note that this is actually 3 PRs. when in doubt, merge the others first.

I got some issue with make distcheck (dist and check worked), related to qucs-core\tests\basic. I will try to reproduce.

thanks. yes -- lets fix issues first, let me know the details.

yesterday, after I merged master, something strange happened (see bd822ea for the workaround). if you have an idea, lets properly fix this as well.

guitorri · 2016-01-25T20:56:52Z

I saw that this includes #361 and #387. I am OK with merging this PR. I also want to see if GitHub will close the intermediate PRs.

The distcheck issue I mentioned did not surfaced again.

I have two small patches to send later. One includes to distdir some pdf figures needed by qucs-doc. If I try to extract and build the tarball made run make dist in another location latex complains about missing figures.

The qucs-test/.git/ directory is also being copied into distdir. Yes, we need to improve this later.

I will merge this and we work from there.

Thank you so much!

* fix `make dist`, `make check` and `make distcheck` * integrate qucs tests into qucs package

felix-salfelder added 22 commits September 28, 2015 22:03

make distcheck work in qucs

836d228

- add SUFFIXES for .h->.moc.cpp rule - add various _HEADERS - distribute qucs.qrc - add several qrc files - add more filter headers - sort out qm rule - add translation files to dist

remove maintainer mode from qucs

6c35c46

using MAINTAINER_MODE does not work, if it it not enabled.

cleanup bootstrap

c2a9741

make distcheck work without --with-mkadms workaround.

c6e7b03

remove maintainer mode condition. rename --with-mkadms to --with-admsxml.

fix an include for libqucs_la

35af66f

remove MAINTAINER_MODE from qucs-core

b19fec1

update README (mostly maintainer-mode)

e125793

let us use -l if we want to.

aa0bd71

this is required to generate qucsdefs.h. still don't advertise unless DEBUG (for some reason).

more DISTCLEANFILES in qucs-core

76ef7be

streamline lex/yacc invocation in qucs-core/src/converter

16f4d0b

autotools does this. dont try manually. (perhaps autotools could not do this back then...)

also streamline lex/yacc in src

9cc63e3

trying to fix the other (cmake) build.

4385ea5

also editing an xml file. unsure, what this is about.

add yacc headers to BUILT_SOURCES

56555d0

revert global bootstrap call in travis.yml

f89de89

(does not work yet, need to fix docbuild first)

remove MAINTAINER_MODE from qucs-doc/configure.ac

cf60cef

remove configure madness from qucs-doc/bootstrap

881f8a4

this works around MAINTAINER_MODE, which is no longer used

distribute and install toplevel examples

72b171a

use one of them in $srcdir sanity check in configure.ac

add missing file.

a91b581

unconditional qucs-doc configuration.

21f28c0

qucs-doc conditional only affects toplevel Makefile.am

cleanup .travis.yml. rely on distcheck

bf2168e

improve bootstrap

470463e

- set AC_CONFIG_AUX_DIR, so automake will not guess (wrongly) - dont mention autogen in output - AM_PROG_AR. required according to automake output (-Wall)

remove redundant calls from travis.yml.

e799cf0

felix-salfelder force-pushed the qucs-test branch from 4b80a48 to 87402fc Compare September 30, 2015 22:38

add more icons

4a95786

felix-salfelder force-pushed the qucs-test branch 6 times, most recently from 3e4a602 to 63c75fc Compare October 1, 2015 22:47

felix-salfelder force-pushed the qucs-test branch 2 times, most recently from 52bedae to 200c6c1 Compare October 4, 2015 19:13

felix-salfelder added 2 commits October 8, 2015 19:53

workaround qucs_typedefs.h

82aec61

this file has unsafe timestamps. use config.h instead. (don't know what else this is used for (cmake?))

optional subdir bypass in bootstrap

0b2a42b

"./bootstrap here" does not recurse. sometimes faster.

felix-salfelder force-pushed the qucs-test branch 4 times, most recently from 5b46c56 to f035506 Compare October 8, 2015 18:28

felix-salfelder added 2 commits October 8, 2015 20:35

rearrange gtest in qucs-core

3e7cb3a

- dont write to $(srcdir) during configure - simplify --with-gtest semantics - dont download gtest automatically - use GTEST_CPPFLAGS for gtest CPPFLAGS. - add gtest download helper TODO: add wget to .travis.yml

remove autogenerated files

c01f00b

felix-salfelder force-pushed the qucs-test branch 3 times, most recently from 68cd410 to 7808de9 Compare October 8, 2015 19:28

felix-salfelder added 4 commits October 8, 2015 21:28

fetch/unpack gtest in .travis.yml

7808de9

add GTEST_TESTS to CLEANFILES

26f2220

cmake: pick gperfapphash.gph from where it is built

75f6f11

felix-salfelder changed the title ~~integrate qucs tests into qucs package (WIP)~~ integrate qucs tests into qucs package Nov 5, 2015

felix-salfelder added 2 commits January 23, 2016 20:54

Merge branch 'master' into qucs-test

a86cad8

add redundant dependency...

bd822ea

.. in an attempt to figure out what's wrong with appvey0r

guitorri added this to the 0.0.19 milestone Jan 25, 2016

guitorri added a commit that referenced this pull request Jan 25, 2016

Merge pull request #389 from felix-salfelder/qucs-test

930b6fe

* fix `make dist`, `make check` and `make distcheck` * integrate qucs tests into qucs package

guitorri merged commit 930b6fe into Qucs:master Jan 25, 2016

felix-salfelder deleted the qucs-test branch January 25, 2016 21:29

guitorri mentioned this pull request Nov 9, 2016

Add 4 new modules(ohmmeter,wattmeter,fasor diagram and temporal diagr… #546

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integrate qucs tests into qucs package#389

integrate qucs tests into qucs package#389
guitorri merged 42 commits intoQucs:masterfrom
felix-salfelder:qucs-test

felix-salfelder commented Sep 30, 2015

Uh oh!

felix-salfelder commented Oct 4, 2015

Uh oh!

felix-salfelder commented Nov 6, 2015

Uh oh!

guitorri commented Jan 24, 2016

Uh oh!

felix-salfelder commented Jan 24, 2016

Uh oh!

guitorri commented Jan 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

felix-salfelder commented Sep 30, 2015

Uh oh!

felix-salfelder commented Oct 4, 2015

Uh oh!

felix-salfelder commented Nov 6, 2015

Uh oh!

guitorri commented Jan 24, 2016

Uh oh!

felix-salfelder commented Jan 24, 2016

Uh oh!

guitorri commented Jan 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants