test: attach error listener to raw pg Pools in remote tests#128
Merged
Conversation
pool.end() resolves before the underlying client sockets actually close; if the testcontainer stops during that gap the server emits a FATAL 57P01 on the still-listening idle client and it escapes as an unhandled error. Library pools go through wrapPgPool which already attaches a handler, but the five raw `new Pool(...)` instances in these test files didn't. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Query Doctor Analysis
2 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, inserted_at desc)
cost 31,003,449 → 1,493 (100% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 154,402 → 8 (100% reduction)
Using assumed statistics (10000000 rows/table). For better results, sync production stats.
Xetera
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pool.on("error", ...)on the five rawnew Pool(...)instances inremote.test.tsandremote-controller.test.ts.Why
pool.end()resolves synchronously once_clientsis empty, but the underlyingclient.end()is still async — the Terminate (X) may not have flushed when the testcontainer is stopped in thefinallyblock. The server then sends FATAL 57P01 to the still-listening idle client, which re-emits on the Pool. Library pools go throughwrapPgPool(src/sql/postgresjs.ts:126) which already installs a handler; the raw test Pools didn't, so the error escaped as unhandled and flaked CI even when every assertion passed.Test plan
npm run typechecknpx vitest run src/remote/remote.test.ts src/remote/remote-controller.test.ts(13/13 green, no unhandled errors)🤖 Generated with Claude Code