fix: keep getQuerySource out of getRecentQueries after reset#136
Merged
Conversation
Postgres strips trailing comments past `;` from the text pg_stat_statements stores, so the marker has to sit before the terminator. Without it, the getQuerySource SELECT survived pg_stat_statements_reset() and broke the non-default-schema reset test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Xetera
approved these changes
May 15, 2026
There was a problem hiding this comment.
Query Doctor Analysis
2 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, inserted_at desc)
cost 31,003,449 → 1,498 (100% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 154,402 → 8 (100% reduction)
Using assumed statistics (10000000 rows/table). For better results, sync production stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetPgStatStatements works with a non-default schema) was failing withexpected 1 to deeply equal +0— one query survivedpg_stat_statements_reset().getQuerySource()had no@qd_introspectionmarker AND its IN-list literals normalize to$1, $2, so neither filter ingetRecentQueries()caught it.-- @qd_introspectionafter the trailing;didn't help: Postgres strips trailing comments past;from the text pg_stat_statements stores (verified empirically). Moved the marker before the terminator so it actually survives.Test plan
npx vitest run src/sync/pg-connector.test.ts— all 7 tests pass locally against postgres:17