feat: include sqlcommenter tags in CI query payload#98
Merged
Conversation
Extract SQLCommenter tags from Analyzer.analyze() and thread them through QueryProcessResult and CiQueryPayload to the Site API. This enables the Site frontend to display route, method, file, and other sqlcommenter metadata for CI-captured queries. Companion to Query-Doctor/Site#2615 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Query Doctor Analysis
28 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, uploader_id, inserted_at desc)
cost 15,922 → 1,639 (90% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 126 → 9 (93% reduction)
Using assumed statistics (10000 rows/table). For better results, sync production stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analyzer.analyze()and include inQueryProcessResulttags: SQLCommenterTag[]toCiQueryPayloadinterfacemapResultToQuery()cases to the Site API payloadContext
Companion to Query-Doctor/Site#2615. The Site repo now accepts and stores
tagsonCiRunQueryResult(optional, defaults to[]). This PR makes the analyzer actually send them.Once both PRs are merged, CI-captured queries will show sqlcommenter metadata (route, method, file, etc.) in the query detail view.
Test plan
tsc --noEmit)QueryProcessResultreturn paths includetagsmapResultToQuery()cases includetags: result.tags🤖 Generated with Claude Code