Skip to content

Feat: Support holes in polygons via a5-rs API#2

Closed
felixpalmer wants to merge 2 commits into
mainfrom
felix/polygons-with-holes
Closed

Feat: Support holes in polygons via a5-rs API#2
felixpalmer wants to merge 2 commits into
mainfrom
felix/polygons-with-holes

Conversation

@felixpalmer

@felixpalmer felixpalmer commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Draft of supporting holes in polygons via the new API in a5-rs. Needs to wait for 0.9.0 release

@felixpalmer felixpalmer requested a review from rustyconover June 12, 2026 11:00
rustyconover
rustyconover approved these changes Jun 12, 2026
View reviewed changes

@rustyconover rustyconover left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! let me know when the new crate is ready and we'll ship it. I love having less code here!

@felixpalmer

felixpalmer commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

@rustyconover 0.9.0 is out & I've updated the PR to work with it. Note the removal of the spherical API functions, these were only ever meant to be internal to A5, let me know if there is some reason they should be included in the DuckDB API. If you're happy, go ahead and merge&release :)

@rustyconover

rustyconover commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I'll take over from here and get it building and released. Thanks!

rustyconover added a commit that referenced this pull request Jun 24, 2026
@rustyconover @claude
Support holes in polygons via a5-rs 0.9.0 API
8c08dab 
Integrates PR #2 (felix/polygons-with-holes) into the v1.5 branch.

- Bump a5 crate 0.8.0 -> 0.9.0.
- a5_polygon_to_cells now takes flattened rings (outer + holes) plus a
  per-ring length array; the a5 crate excludes holes itself, so the C++
  uncompact/set-difference/recompact dance is gone.
- Remove a5_cell_to_spherical / a5_spherical_to_cell (dropped upstream in
  0.9.0), including their FFI bindings, DuckDB registrations, docs, tests.
- Bump extension version to 2026062301.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rustyconover

rustyconover commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Landed on the v1.5 branch as commit 8c08dab (the active release line, which carries the DuckDB v1.5 upgrade that main doesn't). The feature commits were integrated there: a5 crate bumped to 0.9.0, a5_polygon_to_cells now takes flattened rings with holes excluded by the a5 crate, and the deprecated a5_cell_to_spherical/a5_spherical_to_cell functions were removed. Build passes and all tests are green. Closing this PR since it targeted main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rustyconover rustyconover rustyconover approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felixpalmer @rustyconover