Skip to content

Better patch for #37 (missing sidebar on direct comic pages) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilyvion merged 4 commits into from
Dec 8, 2019
Merged

Better patch for #37 (missing sidebar on direct comic pages) #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f71db54
Better fix for missing sidebar
trlkly Dec 8, 2019
eb23f4e
Update version.
trlkly Dec 8, 2019
bbfbf9c
Update version
trlkly Dec 8, 2019
2c8b30b
Update changelog to include description of fix
trlkly Dec 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assets/js/modules/dom-modifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@ export default class DomModifier {

$('#news, #newspost').replaceWith('<qc-news></qc-news>');

if (comicDirective.parent().siblings('.small-2').length === 0) {
// There's no column after the comic: Insert our own
comicDirective.parent().after('<div class="small-2 medium-expand column"></div>');
}
comicDirective.parent().siblings('.small-2').prepend('<qc-extra></qc-extra>');

// Set a base (required by Angular's html5Mode)
Expand Down
5 changes: 4 additions & 1 deletion assets/templates/changeLog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ <h4>NextVersion <small>NextDate</small></h4>
<li></li>
</ul>
-->

<h4>0.6.1 <small>December 8, 2019</small></h4>
<ul>
<li>Fix missing sidebar when loading a comic directly by number in URL.</li>
</ul>
<h4>0.6.0 <small>March 7, 2019</small></h4>
<div class="change-log-entry">
<p class="developer-message">
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "questionable-content-spa",
"version": "0.6.0",
"version": "0.6.1",
"description": "Questionable Content Single-Page Application with Extra Features",
"main": "app.js",
"scripts": {
Expand Down