Automatically retry enqueuing after connection reset#294
Merged
ukd1 merged 1 commit intoQueueClassic:masterfrom Jul 3, 2019
Merged
Automatically retry enqueuing after connection reset#294ukd1 merged 1 commit intoQueueClassic:masterfrom
ukd1 merged 1 commit intoQueueClassic:masterfrom
Conversation
ukd1
approved these changes
Jul 3, 2019
ukd1
added a commit
that referenced
this pull request
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If DB connection is dropped for any reason, QC does
resetthe connection but does not retry enqueuing the job.This PR adds retry-once logic to
enqueueandenqueue_in(and through that toenqueue_at) so that when the initialexecutefails withPGError, it is retried once (after execute's rescue has reset the connection).Rationale: QC should give it's best to ensure the
enqueueresults in a enqueued job in DB, so if the DB connection has gone bad, resetting it is not enough and we should repeat theINSERTalso. Leaving the retry logic to the app code is sub-optimal as then everybody need to implement the same code.I added the retry only to
enqueueandenqueue_in, not toexecute, so that other SQL statements can be executed without automatically retrying on PGError.