-
-
Notifications
You must be signed in to change notification settings - Fork 7
Create cloudrun.yaml #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cloudrun.yaml #429
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| - name: Authenticate to Google Cloud | ||
| uses: google-github-actions/auth@v3 | ||
|
Comment on lines
+1
to
+2
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Invalid GitHub Actions workflow structure. This file is missing required top-level sections and will not execute. GitHub Actions workflows must include:
🔧 Proposed fix: Complete workflow structure+name: Deploy to Cloud Run
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+
+jobs:
+ deploy:
+ runs-on: ubuntu-latest
+
+ permissions:
+ contents: read
+ id-token: write
+
+ steps:
- name: Authenticate to Google Cloud
uses: google-github-actions/auth@v3
+ with:
+ workload_identity_provider: ${{ secrets.WIF_PROVIDER }}
+ service_account: ${{ secrets.WIF_SERVICE_ACCOUNT }}
+
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ # Add additional steps for building and deploying to Cloud RunNote: You'll need to configure the following repository secrets:
🧰 Tools🪛 actionlint (1.7.10)1-1: "jobs" section is missing in workflow (syntax-check) 1-1: "on" section is missing in workflow (syntax-check) 1-1: "workflow" section is sequence node but mapping node is expected (syntax-check) 🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not a valid GitHub Actions workflow as shown. A workflow must define at minimum
name:(optional),on:(required), andjobs:(required). Right now it appears to be only a step fragment, which will cause the workflow to fail to load/execute.Additionally,
google-github-actions/auth@v3generally requires configuration inputs (e.g.,workload_identity_provider+service_accountor a JSON key viacredentials_json). Withoutwith:inputs and without a job context, this step can’t run meaningfully.Suggestion
Convert this into a complete workflow with triggers and a job, and provide the required auth inputs. For example:
(Then add subsequent steps for
gcloudsetup and Cloud Run deploy as needed.) Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this suggestion.