Fix XCTest override error on SPM/Swift4 #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
sunshinejr
commented
Oct 12, 2017
| if let superclass = class_getSuperclass(subclass), superclass === klass { | ||
| block(subclass as! T.Type) // swiftlint:disable:this force_cast | ||
| } | ||
| guard let superclass = class_getSuperclass(subclass), superclass == klass else { continue } |
There was a problem hiding this comment.
I'll need some help here. When using ===, there is still a runtime crash (EXC_BAD_ACCESS). For now I did == and it doesn't crash, but we probably need to find a real problem 🤔
There was a problem hiding this comment.
Looks like using == is valid here:
ikesyo
reviewed
Nov 23, 2017
| if let superclass = class_getSuperclass(subclass), superclass === klass { | ||
| block(subclass as! T.Type) // swiftlint:disable:this force_cast | ||
| } | ||
| guard let superclass = class_getSuperclass(subclass), superclass == klass else { continue } |
There was a problem hiding this comment.
Looks like using == is valid here:
Sources/Quick/QuickSpec.swift
Outdated
| /// discovered powered by Objective-C runtime), so we needed the alternative | ||
| /// way. | ||
| #if swift(>=4) | ||
| override open static var defaultTestSuite: XCTestSuite { |
There was a problem hiding this comment.
This should be class instead of static.
https://developer.apple.com/documentation/xctest/xctestcase/1496289-defaulttestsuite#
|
Thanks for the review @ikesyo! I've changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys!
Here with another SPM fix. This time for Swift 4 specifically. Seems like last time I was using Swift 3.2 for Quick, even though I've built it in with SPM/Swift4. This time, when switching to Swift 4.0 on Quick, I've seen an error due to
XCTest.defaultTestSuite()change. Basically in Swift 3.*XCTest.defaultTestSuite()is a method and in Swift 4.* it is a variable, making the build fail.I've fixed this one using
if swift(>=4), but I'm all ears if you have another fix in mind.Also, this could appear everywhere with Swift 4, not only SPM, but SPM was the only one I’ve tested.
Cheers!