[1.x] QuickSpec+QuickSpec_MethodList should be in the test targets, not in the library targets
#792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
commented
May 23, 2018
| * This method will instantiate an instance of the class on which it is called, | ||
| * returning a list of selector names for it. | ||
| * | ||
| * @warning Only intended to be used in test assertions! |
There was a problem hiding this comment.
As the message said, the function should not be defined in Quick-macOS and so on.
… not in the library targets
ikesyo
force-pushed
the
allselectors-test-only
branch
from
17ef314 to
f732158
Compare
|
Ping @Quick/core |
|
Thanks @sharplet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll say that this is a preliminary task for fixing #785.