Add Swift 5 support to Quick.podspec #911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue #895. Based on Nimble.podspec
Generated by 🚫 Danger |
|
@ethansinjin please, add '5.1' to the list |
|
osx_image for the |
|
@Oleg-Marchik-Neklo I didn't include 5.1 because Xcode 11 is still in beta, and Quick/Nimble doesn't include it either. If any of the project maintainers want to add it, feel free to edit this PR or comment below! |
ikesyo
requested changes
Sep 7, 2019
| env: | ||
| - XCODE_ACTION="build-for-testing test-without-building" | ||
| osx_image: xcode10.1 | ||
| osx_image: xcode10.2 |
There was a problem hiding this comment.
Please don't drop Xcode 10.1 (Swift 4.2) CI. Xcode 10.2 bundles Swift 5, not Swift 4.2. I'll address this.
|
Superseded by #919. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #895. Based on Nimble.podspec
Checklist:
This may require a minor version bump in order to propagate on CocoaPods correctly