Add HTTP status code as code to error object
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not very good to rely on `error.message`, which is string like `Not Found`, to handle specific errors, so it would be really nice to have an access to the actual HTTP status code. That also means the documentation for `REST API` should also be improved by adding information about available HTTP status codes and their meanings.
anryogo
pushed a commit
that referenced
this pull request
Jun 4, 2014
Add HTTP status code as `code` to error object
Contributor
|
|| For instance I expected http://api.quickblox.com/geodata/find.json to return an empty array even if nothing has been found, but in reality it responds with 404 Not Found. Server-team have checked that on geodata and yes, it returns 404 error. But if we fix this, it will break backward compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not very good to rely on
error.message, which is string likeNot Found, to handle specific errors, so it would be really nice to have an access to the actual HTTP status code.That also means the documentation for
REST APIshould be improved by adding information about available HTTP status codes for each API call and their meanings. For instance I expectedhttp://api.quickblox.com/geodata/find.jsonto return an empty array even if nothing has been found, but in reality it responds with404 Not Found.