Skip to content

Conversation

@dimaspirit
Copy link
Contributor

@dimaspirit dimaspirit commented Apr 10, 2017

Make sure that you wrote the tests for your proposed changes and the existing test was success.

qbwebsdk 422

Made/Proposed changes:

  • new Data sample instead of content sample, customobjects sample.

How should this be manually tested?

  • start server by npm run start;
  • go to localhost:8080/samples/data
  • enjoy it )

Does the documentation need an update?
Yes

TODO:

  1. Trying change .png to .svg;
  2. Refactoring;
  3. Make verification of data;
  4. Make QB framework and load all assert on dev and includes assets by absolute path and preload them;
  5. Lint JS, CSS, HTML;

@dimaspirit dimaspirit changed the title WIP - data sample WIP: Data sample May 3, 2017
@dimaspirit dimaspirit changed the title WIP: Data sample Data sample May 4, 2017
@dimaspirit dimaspirit merged commit 85f8af4 into develop May 8, 2017
@dimaspirit dimaspirit deleted the QBWEBSDK-422 branch May 8, 2017 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants