Develop.sprint8.chat sample #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notification messages
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/css/dashboard.css
Outdated
| .message__wrap.m-notification_message { | ||
| display: block; | ||
| color: #778594; | ||
| font-family: Roboto; |
Contributor
There was a problem hiding this comment.
Why do you set font-family? If you set Roboto to body .
Contributor
There was a problem hiding this comment.
And may be need alternative fonts - font-family: Roboto, sans-serif;
dimaspirit
reviewed
Apr 24, 2017
| color: #778594; | ||
| font-family: Roboto; | ||
| font-size: 13px; | ||
| font-weight: 500; |
Contributor
There was a problem hiding this comment.
use font: 500 13px/15px Roboto, sans-serif;
if you set all of property
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/css/dashboard.css
Outdated
| } | ||
|
|
||
| .group_chat__user_list { | ||
| .update_update_chat_name_form { |
Contributor
There was a problem hiding this comment.
update_update - seriously?
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/css/dashboard.css
Outdated
| background: #fff; | ||
| } | ||
|
|
||
|
|
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/css/dashboard.css
Outdated
|
|
||
| .create_dialog_form { | ||
| .create_dialog_form, | ||
| .update_dialog_form { |
Contributor
There was a problem hiding this comment.
Are you can use one selector with modifier for form if you form has equals style.
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/css/dashboard.css
Outdated
| .create_dialog_btn { | ||
| width: 96px; | ||
| flex: 0 0 96px; | ||
| .create_dialog_btn, |
Contributor
There was a problem hiding this comment.
set unified class .btn for buttons, so many repeats
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/css/dialogs.css
Outdated
| } | ||
|
|
||
| .message__avatar.m-user__img_not_loaded, | ||
| .message__avatar.m-typing_uncnown { |
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/css/login.css
Outdated
| font-size: 16px; | ||
| line-height: 19px; | ||
| color: #C5CACE; | ||
| transition: 0.15s; |
Contributor
There was a problem hiding this comment.
better use all properties: what will animate, time, func of animation
dimaspirit
reviewed
Apr 24, 2017
| <form name="loginForm" class="login__form"> | ||
| <div class="login_form__row"> | ||
| <label for="userName">User name</label> | ||
| <input type="text" id="userName" name="userName"/> |
Contributor
There was a problem hiding this comment.
Could you add to spec patterns to input data as username, usergroup
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/js/app.js
Outdated
| logoutBtn = document.querySelector('.j-logout'); | ||
|
|
||
| if(activeTabName){ | ||
| renderParams.tabName = activeTabName |
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/js/listeners.js
Outdated
|
|
||
| var activeTab = document.querySelector('.j-sidebar__tab_link.active'), | ||
| tabType = activeTab.dataset.type, | ||
| dialogType = dialog.type === 1 ? "public" : "chat"; |
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/js/listeners.js
Outdated
| if (message.extension && (message.extension.notification_type === '1' || message.extension.notification_type === 'creating_dialog')) { | ||
| var dialog = dialogModule._cache[message.dialog_id || message.extension.dialog_id]; | ||
|
|
||
| if (message.extension && message.extension.notification_type === '1') { |
dimaspirit
reviewed
Apr 24, 2017
| dialogModule.renderDialog(dialogModule._cache[dialog._id], true); | ||
| } | ||
| }).catch(function(error){ | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
Is it all handle if we don't found the dialog?
dimaspirit
reviewed
Apr 24, 2017
samples/newChat/js/message.js
Outdated
| this.container = null; | ||
| this.attachmentPreviewContainer = null; | ||
| this.typingTymeout = appConfig.typingTymeout || 3 | ||
| this.typingTymeout = appConfig.typingTymeout || 3; |
Contributor
There was a problem hiding this comment.
typingTymeout => typingTimeout
dimaspirit
reviewed
Apr 24, 2017
samples/webrtc/js/helpers.js
Outdated
| } else { | ||
| /** In first trying to login */ | ||
|
|
||
| console.log(userRequiredParams); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto login
Updating dialog
Notification messages