Skip to content

WIP: Ability to use multiple QB instances, refactored logs format and bug fixes #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dimaspirit merged 59 commits into from
May 22, 2017
Merged

WIP: Ability to use multiple QB instances, refactored logs format and bug fixes #231

dimaspirit merged 59 commits into from
May 22, 2017

Conversation

@soulfly
Copy link
Contributor

@soulfly soulfly commented Apr 25, 2017 •
edited
Loading

Made/Proposed changes:

  1. ability to use multiple QB instances
  2. refactored logs format
  3. fixed an issue with recursion when do QB.chat.disconnect inside QB.chat.connect's callback (Node.js)
  4. new callback onKickOccupant(dialogId, initiatorUserId) to handle a case where User2 joined chat dialog and User1 removed him from occupants.
  5. Fixed: QB.chat.privacylist.delete method does not work under Node.js.
  6. Fixed: methods to decline the use of active/privacy lists (QB.chat.privacylist.setAsDefault('', callback) and QB.chat.privacylist.setAsActive('', callback)) does not work properly. Also, now you can pass null instead of empty string '' to decline.
  7. Fixed: QB.chat.privacylist.getNames method does not return anything if a user does not have any active/default lists.
  8. Fixed: QB.chat.privacylist.getNames returns all names except active/default at names key under Node.js. Made it similar to browser env behaviour.
  9. Added task npm run buildNotMinified
  10. Added Karma/Istanbul code coverage tools. To start use the following comand: node_modules/.bin/karma start karma.conf.js. To see a report look at subdirectory coverage in the default location. Warning! Before run you need to rebuild sdk with buildNotMinified task.
  11. new callbacks onJoinOccupant(dialogId, userId) and onLeaveOccupant(dialogId, userId) to handle group dialog changes.
  12. QB.chat.muc.listOnlineUsers method not returns an array of integers instead of array of strings.
  13. Fixed: onMessageErrorListener does not work under Node.js
  14. Fixed: QB.chat.privacylist.update method does not work properly when change deny-> allow.
  15. Fixed: QB.users.resetPassword always returns an error
  16. more Chat tests

How should this be manually tested?
do 'npm install'
run tests

Does the documentation needs an update?

  1. to describe new callback functionality onKickOccupant(dialogId, initiatorUserId)
  2. to describe new callback functionality onJoinOccupant(dialogId, userId)
  3. to describe new callback functionality onLeaveOccupant(dialogId, userId)

@soulfly soulfly changed the title Ability to use multiple QB instances, refactored logs format and bug fixes WIP: Ability to use multiple QB instances, refactored logs format and bug fixes Apr 25, 2017
dimaspirit
dimaspirit reviewed May 11, 2017
View reviewed changes
spec/QB-UsersSpec.js Outdated
expect(res).not.toBeNull();
expect(res.full_name).toBe('QuickBlox Test');
userId = res.id;
console.info(userId);
Copy link
Contributor

@dimaspirit dimaspirit May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console or this need for something?

Copy link
Contributor Author

@soulfly soulfly May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

dimaspirit
dimaspirit reviewed May 11, 2017
View reviewed changes
spec/QB-UsersSpec.js Outdated
it('can reset password', function(done) {

QB.users.resetPassword(QBUser1.email, function(err, res){
console.log(err);
Copy link
Contributor

@dimaspirit dimaspirit May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this console?

Copy link
Contributor Author

@soulfly soulfly May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

dimaspirit
dimaspirit reviewed May 11, 2017
View reviewed changes
spec/QB-UsersSpec.js
});

afterAll(function(done){
QB.destroySession(function (err, result){
Copy link
Contributor

@dimaspirit dimaspirit May 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't check err or result?

Copy link
Contributor Author

@soulfly soulfly May 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

dimaspirit
dimaspirit reviewed May 11, 2017
View reviewed changes
spec/config.js
'password': "js_jasmine11",
'email': "js_jasmine11@quickblox.com"

var NEW_SERVER = false;
Copy link
Contributor

@dimaspirit dimaspirit May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the New_server?

Copy link
Contributor Author

@soulfly soulfly May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our new implementation with fully clustered Chat server solution, will be released in some near future.

@dimaspirit
Copy link
Contributor

dimaspirit commented May 12, 2017

Also, I remove the src/modules/qbLocation.js, in your pull request it returned, so need to merge or remove this file manually.

@dimaspirit
Copy link
Contributor

dimaspirit commented May 12, 2017

Also, need to describe in release notes that need to update npm dependencies.

Igor Khomenko and others added 4 commits May 12, 2017 18:39
cleanup
f745e75
merged
8f9929a
@dimaspirit
Merge remote-tracking branch 'remotes/origin/develop' into kafka
b7627d8 
# Conflicts:
#	quickblox.min.js
#	samples/chat/js/config.js
#	spec/QB-PushnotificationsSpec.js
#	spec/QB-UsersSpec.js
@dimaspirit
build add
1407b1f
@dimaspirit dimaspirit merged commit 4814390 into develop May 22, 2017
@dimaspirit dimaspirit deleted the kafka branch May 22, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dimaspirit dimaspirit dimaspirit left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soulfly @dimaspirit