WIP: Managment session (now - refactoring) #241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagmentSession # Conflicts: # quickblox.min.js
…nagmentSession # Conflicts: # quickblox.min.js # samples/newChat/css/dashboard.css # samples/newChat/css/style.css # samples/newChat/index.html # samples/newChat/js/QBconfig.js # samples/newChat/js/app.js # samples/newChat/js/dialog.js # samples/newChat/js/helpers.js # samples/newChat/js/listeners.js # samples/newChat/js/message.js # samples/newChat/js/user.js
…nagmentSession # Conflicts: # quickblox.min.js
…nagmentSession # Conflicts: # quickblox.min.js # samples/newChat/js/QBconfig.js # spec/QB-LocationSpec.js # spec/SpecRunner.html
need add local storage
add build
…nagmentSession # Conflicts: # quickblox.min.js # spec/QB-ChatSpec.js # src/modules/qbAuth.js # src/qbProxy.js
…nagmentSession # Conflicts: # quickblox.min.js
soulfly
reviewed
May 29, 2017
src/qbProxy.js
Outdated
| }; | ||
|
|
||
| if(config.sessionManagement.enable) { | ||
| if(errorMsg.code === 401) { |
Contributor
There was a problem hiding this comment.
what does this 'if' check? what case/situation?
Would be greate to have some comments what is happening here
soulfly
reviewed
May 29, 2017
src/qbProxy.js
Outdated
| if(params.url.indexOf(config.urls.login) !== -1 && params.type === 'DELETE') { | ||
| callback(); | ||
| } else if(params.url.indexOf(config.urls.login) !== -1 && params.type === 'POST') { | ||
| self.sessionManager.saveUserParams(params); |
Contributor
There was a problem hiding this comment.
Правильно будет сохранять юзер кренделя при success ответе.
В противном случае логин может быть неуспешным и тогда в кеше будут невалидные данные.
И тогда при следующем запросе они я так понимаю будут использоваться?
Contributor
There was a problem hiding this comment.
А, я вижу, что ты это уже делаешь внутри success. Тогда тут зачем сохранять?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that you wrote the tests for your proposed changes and the existing test was success.
Made/Proposed changes:
It doesn't include 3-rd party service sessions for now.
How should this be manually tested?
Does the documentation need an update?
Yes