QBWEBSDK-653 #337
Merged
QBWEBSDK-653 #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixed problem with connection to the chat one by one
…hat.disconnect() stops reconnection actions
…fig.js (5 sec by default)
dimaspirit
reviewed
May 8, 2018
| audio: self.mediaParam.audio || false, | ||
| video: self.mediaParam.video || false | ||
| }) | ||
| .then(self._replaceTracks.bind(self)) |
Contributor
There was a problem hiding this comment.
wrap in function or bind the context when instance creating
dimaspirit
approved these changes
May 8, 2018
soulfly
reviewed
May 10, 2018
| }; | ||
|
|
||
| /** | ||
| * Switch media stream into audio/video element and replace tracks in peers |
soulfly
reviewed
May 10, 2018
| * @param {string} The Id of an element to switch tracks | ||
| * @param {function} A callback to get a result of the function | ||
| */ | ||
| WebRTCSession.prototype.switchVideoSource = function(deviceId, callback) { |
Contributor
There was a problem hiding this comment.
So is this deviceId or "The Id of an element" ? not clear, please unify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The possibility to switch cameras was added for the Firefox.
Other browsers - comming soon.