Merged
Conversation
…tLogin; fixes race condition causing testLogin flakiness tests that wait on DummyClientPacketHandler#disconnectFromServerLatch are still flaky: NetworkTest::connectClient can throw BindException
…cketHandler#disconnectFromServerLatch waits replace NetworkTest::testTakenUsername's client1 diconnect call with kickAfterTest repeat each test 100 times (except testUnapprovedMessage which takes 3 sec. per success) warn about over-repeating tests that wait on DummyClientPacketHandler#disconnectFromServerLatch
supersaiyansubtlety
added
bug
ix0rai
approved these changes
Jan 20, 2026
Member
ix0rai
left a comment
ix0rai
left a comment
There was a problem hiding this comment.
looks great! excited to not be dealing with this on the ci literally every other second
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly fixes
NetworkTestflakiness.Merry happy.
testLoginandtestTakenUsernameto avoid race conditionsEnigmaClient::disconnectcalls after waiting onDummyClientPacketHandler.disconnectFromServerLatchfixes race condition where the
kickcalls of servers' client threads sent packets that were received by other tests' clientsWarning
testTakenUsernameis still flaky on CII didn't add repetitions for
testTakenUsernamebecause it's still flaky on CI; I can't reproduce the failures locally.I thought the issue might be that the build workflow runs on jdk 17+20 were interfering with each other, but it's still flaky when they're sequential (10,000 reps here):