fix(cli): show newest-first history for Ctrl+R command search#2425
Merged
tanzhenxin merged 1 commit intoQwenLM:mainfrom Mar 18, 2026
Merged
Conversation
kkhomej33-netizen
requested review from
DennisYu07,
DragonnZhang,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Shell-mode already surfaces history in newest-first order, but non-shell command search was using in oldest-first order. That made the two reverse-search experiences inconsistent and pushed recent entries below older ones.
Testing
✓ |@qwen-code/qwen-code| src/ui/components/InputPrompt.test.tsx (97 tests | 1 skipped) 12537ms
✓ InputPrompt > paste auto-submission protection > should allow submission after paste protection timeout 760ms
✓ InputPrompt > large paste placeholder > should expand placeholder to full content on submit 762ms
✓ InputPrompt > large paste placeholder > should expand same-size placeholders correctly when #2 appears first 817ms
✓ InputPrompt > large paste placeholder > should write expanded placeholder content to shell history 761ms
Test Files 1 passed (1)
Tests 96 passed | 1 skipped (97)
Start at 14:16:59
Duration 17.44s (transform 2.14s, setup 40ms, collect 4.10s, tests 12.54s, environment 381ms, prepare 99ms)