GetConstructorName cannot handle Angular#164
Merged
codercatdev merged 4 commits intoQwikDev:mainfrom May 2, 2022
Merged
Conversation
This is a solution for, and should close QwikDev#97 Angular has zone.js and the constructor names cannot be fetched from there
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Excuse me for the "bad quality PR", but this shows the way it can be done. I lack the time and insight to make this a clean fix. |
codercatdev
suggested changes
May 2, 2022
Contributor
codercatdev
left a comment
codercatdev
left a comment
There was a problem hiding this comment.
This looks good, I think we should take the opportunity to at least add a console.error within the catch. What do you think @adamdbradley?
Contributor
Author
|
With the notion of this being a potentially good fix, I spent some time fixing the build errors as a result of the typing; and making the fix a little bit cleaner. Feel free to come back to me with any logging changes; or add them to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solution for, and should close #97
Angular has zone.js and the constructor names cannot be fetched from there