Propagate pushState/replaceState inside worker#172
Merged
adamdbradley merged 9 commits intoQwikDev:mainfrom May 24, 2022
Merged
Propagate pushState/replaceState inside worker#172adamdbradley merged 9 commits intoQwikDev:mainfrom
adamdbradley merged 9 commits intoQwikDev:mainfrom
Conversation
…opagation back to main thread
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
quickshiftin
left a comment
quickshiftin
left a comment
There was a problem hiding this comment.
This looks like a great addition to the library along with some cleanup.
|
@steve8708 @adamdbradley any progress on this? This is blocking us from using Partytown |
|
I'm curious about this as well. |
|
@adamdbradley this doesn't seem to work for GA 4 Enhanced Measurement Browser History Events (pop/push state) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I was investigating issue with GTM inside next.js app. I noticed that tag manager assigns custom pushState/replaceState to forward history changes on SPA. However, Partytown never forwards those calls to worker.
An issue describing this problem was already reported here: #165
This MR fixes the problem.