Skip to content

Conversation

@nnelgxorz
Copy link
Contributor

@nnelgxorz nnelgxorz commented Aug 10, 2022

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Removes all docs content referencing <Host>, useHostElement() and tagName

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@nnelgxorz
Copy link
Contributor Author

nnelgxorz commented Aug 10, 2022

@manucorporat I can delete this file, but maybe you want to rework it to explain the doc comments Qwik uses now?

https://github.com/BuilderIO/qwik/blob/main/packages/docs/src/routes/docs/components/anatomy/index.mdx

@nnelgxorz nnelgxorz marked this pull request as ready for review August 11, 2022 00:57
@manucorporat
Copy link
Contributor

Going to merge! I think it's a great change better than what we have now, lets merge and iterate from here!

Thanks a lot for the PR! as usual amazing job!

@manucorporat manucorporat merged commit e9d9895 into QwikDev:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants