Skip to content

Conversation

@rajington
Copy link
Contributor

What is it?

  • Docs / tests

Description

Some React examples had unnecessary $ or missed things like key (which would be good to call out if qwik behaves differently).

Use cases and why

    1. Better comparison to status quo

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • [NA] Added new tests to cover the fix / functionality

some React examples had unnecessary `$` or missed things like `key` (which would be good to call out if qwik behaves differently)
Copy link
Contributor

@farukEncoded farukEncoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you will need those $ signs here. and also an extra pair of curly braces. like this

style={{
      'background': `rgb(${red}, ${green}, ${blue})`
    }}

@manucorporat manucorporat merged commit 2b790ab into QwikDev:main Aug 22, 2022
@manucorporat
Copy link
Contributor

Thanks a lot for the PR! merged!

manucorporat pushed a commit to youngboy/qwik that referenced this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants