Skip to content

Conversation

@robisim74
Copy link
Contributor

fix #1016

What is it?

  • Feature / enhancement
  • [ x] Bug
  • Docs / tests

Description

After the refactoring of route sorting, optional route parameters are not working as expected: /[...x]/y < /[...x]
The problem is that the check of the ...rest is done on the route id and not on the pathname.
The units tests passed the same because in the test the id was initialized with the pathname.

@adamdbradley

Use cases and why

https://example.com/sku/[...skuId]/details
Should match: https://example.com/sku/1234/details

Checklist:

  • [x ] My code follows the developer guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@manucorporat
Copy link
Contributor

Can you fix / add some new tests that would fail without the fix?!

@robisim74
Copy link
Contributor Author

@manucorporat Done

@manucorporat manucorporat merged commit 1455aee into QwikDev:main Aug 21, 2022
@manucorporat
Copy link
Contributor

Thank you so much @robisim74 ! you rock!
we will release a new version shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qwik City - Optional route parameters not working as expected from v0.0.33

2 participants