Skip to content

Add Yaml Type #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2022
Merged

Add Yaml Type #1086

merged 1 commit into from
Aug 20, 2022

Conversation

@nnelgxorz
Copy link
Contributor

@nnelgxorz nnelgxorz commented Aug 20, 2022 •
edited
Loading

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Replaces the any type for front matter attributes with a Yaml type per this comment: #1075 (comment)

export type Yaml = string | number | boolean | null | { [attrName: string]: Yaml } | Yaml[];

export interface FrontmatterAttrs {
  [attrName: string]: Yaml;
}

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@manucorporat manucorporat merged commit b8bd67f into QwikDev:main Aug 20, 2022
@manucorporat
Copy link
Contributor

Thanks a lot for the PR!

youngboy added a commit to youngboy/qwik that referenced this pull request Aug 21, 2022
@youngboy
Merge branch 'main' into docs-search
e91e224 
* main:
  feat: allow typeof onGet for DocumentHead (QwikDev#1065)
  docs: fix Syntax Error in React Counter Component (QwikDev#1076)
  docs: Add missing endpoint types to routing overview. (QwikDev#1064)
  fix: cloudflare pages starter (QwikDev#1083)
  feat: static site generation (QwikDev#1048)
  fix: root styles rendering (QwikDev#1095)
  docs: clarify useEffect usage a bit that can watch (QwikDev#1090)
  fix: useMount rendering order is respected (QwikDev#1094)
  feat: add Yaml Type (QwikDev#1086)
  fix: useClientEffect() runs in client-side mounted cmps (QwikDev#1092)
  feat: containerAttributes (QwikDev#1089)
  fix: properly serialize resources (QwikDev#1087)
  feat/fix: Export mdx frontmatter variables to the developer (QwikDev#1075)
  docs: Update README.md - Fix broken links (QwikDev#1071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nnelgxorz @manucorporat