Skip to content

Conversation

yjaaidi
Copy link
Contributor

@yjaaidi yjaaidi commented Jun 21, 2022

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@mhevery mhevery enabled auto-merge (squash) June 24, 2022 21:52
@mhevery
Copy link
Contributor

mhevery commented Jun 24, 2022

Please fix the missing new line, or just run yarn lint

auto-merge was automatically disabled June 25, 2022 11:38

Head branch was pushed to by a user without write access

@yjaaidi
Copy link
Contributor Author

yjaaidi commented Jun 25, 2022

Done! Sorry I edited the file directly on github initially 😅

@shairez
Copy link
Contributor

shairez commented Jun 26, 2022

Great minds think alike @yjaaidi 😛😅

(didn't see you already did this)
#661

@yjaaidi
Copy link
Contributor Author

yjaaidi commented Jun 26, 2022

👯‍♂️😂

@shairez
Copy link
Contributor

shairez commented Jun 27, 2022

btw @mhevery - yarn lint didn't auto-fix it for me... I needed to do prettier --write README.md to have it fix

@adamdbradley adamdbradley enabled auto-merge (squash) June 27, 2022 13:31
@adamdbradley adamdbradley merged commit 2df99c2 into QwikDev:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants