Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/qwik/src/core/object/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,8 @@ const collectSubscriptions = (subs: SubscriberMap, collector: Collector) => {
});
};

const collectQObjects = (obj: any, collector: Collector) => {
const collectQObjects = (input: any, collector: Collector) => {
let obj = input;
if (obj != null) {
if (typeof obj === 'object') {
const target = getProxyTarget(obj);
Expand Down Expand Up @@ -740,12 +741,12 @@ const collectQObjects = (obj: any, collector: Collector) => {

if (isArray(obj)) {
for (let i = 0; i < obj.length; i++) {
collectQObjects(obj[i], collector);
collectQObjects(input[i], collector);
}
} else {
for (const key in obj) {
if (Object.prototype.hasOwnProperty.call(obj, key)) {
collectQObjects(obj[key], collector);
collectQObjects(input[key], collector);
}
}
}
Expand Down
22 changes: 14 additions & 8 deletions starters/apps/e2e/src/components/render/render.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
import { component$, useStore, Host } from '@builder.io/qwik';

export const Render = component$(() => {
const state = useStore({
count: 0,
});
if (state.count === 3) {
return null;
}
const state = useStore(
{
counter: {
count: 0,
},
},
{ recursive: true }
);
return (
<Host>
<button
onClick$={() => {
state.count++;
state.counter.count++;
}}
>
Rerender {state.count}
<Child counter={state.counter}></Child>
</button>
</Host>
);
});

export const Child = component$((props: { counter: { count: number } }) => {
return <Host>Rerender {props.counter.count}</Host>;
});
15 changes: 15 additions & 0 deletions starters/e2e/e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -521,4 +521,19 @@ test.describe('e2e', () => {
await expect(logs).toHaveText(logsStr);
});
});

test.describe('render', () => {
test.beforeEach(async ({ page }) => {
await page.goto('/e2e/render');
page.on('pageerror', (err) => expect(err).toEqual(undefined));
});

test('should load', async ({ page }) => {
const button = await page.locator('button');

await expect(button).toHaveText('Rerender 0');
await button.click();
await expect(button).toHaveText('Rerender 1');
});
});
});