Skip to content

fix(core): prevent all events #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2022
+20 −4
Merged

fix(core): prevent all events #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea3b69f
fix(core): prevent all events
manucorporat Jun 28, 2022
a5af560
🍣
manucorporat Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/qwik/src/qwikloader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,12 @@ export const qwikLoader = (doc: Document, hasInitialized?: number, prefetchWorke
};

const dispatch = async (element: Element, eventName: string, ev: Event) => {
if (element.hasAttribute('preventdefault:' + eventName)) {
ev.preventDefault();
}
for (const onPrefix of ON_PREFIXES) {
const attrValue = element.getAttribute(onPrefix + eventName);
if (attrValue) {
if (element.hasAttribute('preventdefault:' + eventName)) {
ev.preventDefault();
}

for (const qrl of attrValue.split('\n')) {
const url = qrlResolver(element, qrl);
if (url) {
Expand Down
17 changes: 17 additions & 0 deletions starters/apps/e2e/src/components/events/events.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export const Events = component$(() => {
const store = useStore({
countTransparent: 0,
countWrapped: 0,
countAnchor: 0,
});

return (
Expand All @@ -16,9 +17,25 @@ export const Events = component$(() => {
store.countWrapped++;
}}
></Buttons>
<p>
<a href="/" preventdefault:click id="prevent-default-1">
Should prevent default
</a>
</p>
<p>
<a
href="/"
preventdefault:click
id="prevent-default-2"
onClick$={() => store.countAnchor++}
>
Should count
</a>
</p>

<p id="count-transparent">countTransparent: {store.countTransparent}</p>
<p id="count-wrapped">countWrapped: {store.countWrapped}</p>
<p id="count-anchor">countAnchor: {store.countAnchor}</p>
</Host>
);
});
Expand Down