Skip to content

Conversation

@craigshoemaker
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Edit pass

Use cases and why

n/a

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Qwik needs to track the application state for two reasons:
1. Application state needs to be serialized on application pause (and deserialize on application resume.)
2. Qwik needs to create subscriptions on stores so that it can know which components need to be re-rendered (if Qwik would not track subscription information then it would have to re-render the whole application which would defeat the lazy-loading.)
1. To serialize data when the application pauses, and deserialize as the application resumes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would modify it to "pauses on the server" and "resumes on the client"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That keeps it much more explicit

@shairez
Copy link
Contributor

shairez commented Jul 20, 2022

Thanks @craigshoemaker !
Reviewed it and it looks better and shorter
let me know what you think about the comments

Copy link
Contributor Author

@craigshoemaker craigshoemaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shairez - here's those tweaks :)

Qwik needs to track the application state for two reasons:
1. Application state needs to be serialized on application pause (and deserialize on application resume.)
2. Qwik needs to create subscriptions on stores so that it can know which components need to be re-rendered (if Qwik would not track subscription information then it would have to re-render the whole application which would defeat the lazy-loading.)
1. To serialize data when the application pauses, and deserialize as the application resumes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That keeps it much more explicit

@mhevery mhevery merged commit 00ed32a into QwikDev:main Jul 20, 2022
@craigshoemaker craigshoemaker deleted the patch-4 branch July 20, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants