Skip to content

Conversation

@isaac-mcfadyen
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

This PR makes a couple of related changes.

  • changes http://server to https://example.com because it's more clear
  • changes the term "Slugs" to "Path Parameters" because it's more generic
  • makes a few typo fixes and changes some words to improve readability

Checklist:

@shairez
Copy link
Contributor

shairez commented Jul 18, 2022

Thanks @isaac-mcfadyen ! 🙏
Awesome improvements!

Merging it now

@shairez shairez changed the title Update Routing docs docs: Update Routing docs Jul 18, 2022
@shairez shairez merged commit 9a3da95 into QwikDev:main Jul 18, 2022
- index.tsx # https://example.com/
- some/
- index.tsx # http://server/some
- index.tsx # https://server/some
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed one...

@@ -0,0 +1,45 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming this file requires a rename in INDEX file as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants