feat: reactive var props #8156
feat: reactive var props #8156
Conversation
🦋 Changeset detectedLatest commit: 86e3a98 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
force-pushed
the
v2-reactive-var-props
branch
from
577abec to
56454b0
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| let propsAreDifferent = false; | ||
| if (vNodeProps) { | ||
| const effects = vNodeProps[_PROPS_HANDLER].$effects$; | ||
| const constPropsDifferent = handleChangedProps( |
There was a problem hiding this comment.
let's only do this if the key is different
There was a problem hiding this comment.
but to know if key is changed we need to run it anyway
| // to this signal. | ||
| ensureContainsBackRef(effectSubscription, target); | ||
| addQrlToSerializationCtx(effectSubscription, store.$container$); | ||
| addQrlToSerializationCtx(effectSubscription, '$container$' in store ? store.$container$ : null); |
There was a problem hiding this comment.
add a comment here to say it's to avoid subscribing?
| const owner = value[_OWNER]; | ||
| output(TypeIds.PropsProxy, [_serializationWeakRef(owner), owner.varProps, owner.constProps]); | ||
| output(TypeIds.PropsProxy, [ | ||
| _serializationWeakRef(owner), |
There was a problem hiding this comment.
I think we should take this out, and instead add a _serializationWeakRef(propsProxy) to jsxNode, and do propsProxy.owner = jsxNode in inflate of jsxNode
There was a problem hiding this comment.
you cant have varprops and const props without owner, so how we can inflate propsproxy then?
There was a problem hiding this comment.
hmm ok to fix this we have to move ownership of the props to propsproxy, as soon as it is created. But we shouldn't create it for every jsxnode so we must support both paths.
I think that can go in another PR.
Varixo
force-pushed
the
v2-reactive-var-props
branch
from
a05bcd7 to
5746b46
Compare
Make props proxy more reactive by adding effects for var props like a store.