fix: serialize correctly null or undefined value for signals #8160
Conversation
🦋 Changeset detectedLatest commit: 1fc309c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
force-pushed
the
v2-undefined-default-effects-value
branch
from
9b8904d to
6d70fd3
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Varixo
force-pushed
the
v2-undefined-default-effects-value
branch
from
6d70fd3 to
eb69e4b
Compare
| } else { | ||
| output(TypeIds.Signal, [value.$untrackedValue$, ...(value.$effects$ || [])]); | ||
| const v = value.$untrackedValue$; | ||
| const keepUndefined = v === undefined; |
There was a problem hiding this comment.
I don't think this is needed, [][0] is undefined
There was a problem hiding this comment.
it is needed, but you are right, its bugged. It should keep only value if effects are undefined. I pushed some changes
There was a problem hiding this comment.
I don't get it, if you don't keep undefined, it will be an empty array and it won't create the effects set?
There was a problem hiding this comment.
its for value, not effects
There was a problem hiding this comment.
oh right, missing value means invalid, not undefined
Varixo
force-pushed
the
v2-undefined-default-effects-value
branch
from
eb69e4b to
1fc309c
Compare
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
Correctly serialize null or undefined value.
Remove only undefined values during serialization.
Make default undefined value for effects and back refs instead of null