fix(qwikloader): don't trigger document and window events for normal events #8170
+86
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 23b3dcd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
changed the title
Varixo
force-pushed
the
v2-qwikloader-document-event-fix
branch
from
8b493a1 to
5a4ea31
Compare
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
wmertens
requested changes
Nov 18, 2025
| }); | ||
| expect(result.html).toContain( | ||
| '(window.qwikevents||(window.qwikevents=[])).push("focus", "-my---custom", "click", "dblclick", "another-custom", "blur")' | ||
| '(window.qwikevents||(window.qwikevents=[])).push(":focus", ":-my---custom", ":click", ":dblclick", ":another-custom", ":blur")' |
Member
There was a problem hiding this comment.
Let's add document and windows events here too
Varixo
force-pushed
the
v2-qwikloader-document-event-fix
branch
2 times, most recently
from
8ce34f6 to
3df04b1
Compare
Varixo
force-pushed
the
v2-qwikloader-document-event-fix
branch
from
3df04b1 to
23b3dcd
Compare
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't trigger document and window events for normal events