Skip to content

fix: revisit public apis #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2022
Merged

fix: revisit public apis #820

merged 4 commits into from
Jul 21, 2022

Conversation

@manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Jul 21, 2022 •
edited
Loading

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Removed:

  • useResume
  • useVisible
  • useWaitOn

Modified

  • run to eagerness

Fixed

  • useClientEffect() with load eagerness

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

antoinepairet
antoinepairet reviewed Jul 21, 2022
View reviewed changes
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb71ba0
Status:⚡️  Build in progress...

View logs

antoinepairet
antoinepairet approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@antoinepairet antoinepairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@manucorporat manucorporat merged commit e6bbf39 into main Jul 21, 2022
@manucorporat manucorporat deleted the fix-api-cleanup branch July 21, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antoinepairet antoinepairet antoinepairet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manucorporat @antoinepairet