DX: Event Handler Types #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'document:onVisible'?: QRL<(event: Event, el: Element) => any>; | ||
|
|
||
| 'document:onVisibilityChange$'?: (event: Event, el: Element) => any; | ||
| 'document:onVisibilityChangeQrl'?: QRL<(event: Event, el: Element) => any>; |
There was a problem hiding this comment.
Just to clarify, remove both of these events or just the Qrl variant?
There was a problem hiding this comment.
Cool. Also, document:onLoad$ and document:onScroll$ should already be generated from the new types. Should I delete those too?
|
Love this PR! lets get it done and merge! |
|
Havent tested this change, but i am worried about the autocompletion of events, like this: is that still working? |
|
Yep! It's still working for me. But now unknown/custom events will have type Event instead of any. 👍 |
|
It's a trick React uses for the same problem: |
|
Amazing! going to merge another PR first, then this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Adds autocompletions for host:on, document:on, window:on and preventDefault: attributes.
Use cases and why
Checklist: