DX: Refine useEndpoint generic #841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Currently it is hard to type your useEndpoint call to your endpoint function.
Consider we have an
onGetdefined as anEndpointHandler<string>Current behavior:
Of course, you could type it yourself, ie
useEndpoint<string>, but any changes to the return type ofonGetdo not trigger a type error foruseEndpoint, making it a brittle solution. Also, you have the option of incorrectly type youruseEndpointcall and not receiving an error until runtime. 😬By adding a little helper type to the useEndpoint definition, we can check the generic, and if T extends EndpointHandler, extract the EndpointHandler type, otherwise use the original T type.
This allows developers to pass the relatively terse
useEndpoint<typeof onGet>()and receive proper typing.This gives the following behavior:
Checklist: