Skip to content

Conversation

@robisim74
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Add prerequisites on Windows to CONTRIBUTING.md, and fix tests on Windows

Use cases and why

Build & test the framework on Windows machines (#794)

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@shairez
Copy link
Contributor

shairez commented Jul 27, 2022

Thanks @robisim74 ! 🙏

And I'm guessing that in the CONTRIBUTING doc we should also add that we need to run make install-rust-deps?
@manucorporat WDYT?

Plus, @robisim74 - there is prettier issue that need fixing in this PR (please run it locally to verify) thanks!

@adamdbradley adamdbradley merged commit 87a0c2f into QwikDev:main Jul 30, 2022
@adamdbradley
Copy link
Contributor

Thanks for the updates! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants