Skip to content

Conversation

@mhevery
Copy link
Contributor

@mhevery mhevery commented Jul 31, 2022

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 31, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e719c4b
Status: ✅  Deploy successful!
Preview URL: https://43ce1f93.qwik-docs.pages.dev
Branch Preview URL: https://pr-qwik-sdk.qwik-docs.pages.dev

View logs

Copy link
Contributor Author

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@mhevery mhevery enabled auto-merge (squash) August 2, 2022 15:33
@gitguardian
Copy link

gitguardian bot commented Aug 3, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2584471 Generic High Entropy Secret 98c2645 packages/docs/src/layouts/builder/builder.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mhevery mhevery merged commit 5597152 into main Aug 3, 2022
@mhevery mhevery deleted the pr-qwik-sdk branch August 3, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants